Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_cookie_domain method to SessionMiddleware #730

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add with_cookie_domain method to SessionMiddleware #730

merged 1 commit into from
Oct 30, 2020

Conversation

rhuffus
Copy link
Contributor

@rhuffus rhuffus commented Oct 30, 2020 •
edited
Loading

We are using tide as a session/authentication context and we need to set the domain of the cookie as the root domain on the SessionMiddleware.

This PR adds the hability to set de cookie domain through the SessionMiddleware builder.

jbr
jbr approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbr jbr merged commit 9341662 into http-rs:main Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhuffus @jbr